Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase number of items per page for default Query Loop Block #35603

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Increase number of items per page for default Query Loop Block #35603

merged 1 commit into from
Oct 15, 2021

Conversation

amustaque97
Copy link
Member

@amustaque97 amustaque97 commented Oct 13, 2021 •
edited
Loading

Fixes #32638

Description

There’s a bit of a confusion point in the Query Block with Items per Page. Despite having multiple published posts only one appeared by default. I found the controls in the Block Toolbar to increase but also found it a bit cumbersome to toggle between the Block Toolbar and Block Sidebar to refine the underlying query.

default.query.mov

How has this been tested?

  • Switch to this PR and run the project
  • Create at least 3 post
  • Create/edit 4 posts and add query block by typing /query
  • Verify query block is showing 3 posts.

Screenshots

image

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

cc @ntsekouras @annezazu

@ntsekouras ntsekouras added [Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement. labels Oct 15, 2021
ntsekouras
ntsekouras approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @amustaque97 🚀

@ntsekouras ntsekouras merged commit 2d3d0f3 into WordPress:trunk Oct 15, 2021
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 15, 2021
@amustaque97 amustaque97 deleted the add/increase-item-per-page branch October 15, 2021 13:01
@annezazu
Copy link
Contributor

Thanks so much for fixing this :D This has been a repeated piece of feedback with the outreach program and it's lovely to see it resolved.

@npneeraj npneeraj mentioned this pull request Feb 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.8
Development

Successfully merging this pull request may close these issues.

Increase number of items per page for default Query Loop Block
3 participants
@amustaque97 @annezazu @ntsekouras